Skip to content
Permalink
Browse files

Bug 1532893 - Retry packages tasks when snapshot.debian.org doesn't r…

…espond. r=dustin

Bug 1486071 intended to fix this, but while the tasks are setup to
restart on exit status 100, there are multiple failure cases where
snapshot.debian.org doesn't respond and the exit status is not 100.

One is dget, when downloading package sources from snapshot.debian.org.
Eventually, those should move to fetch tasks, but in the meantime, we
bubble up get errors with an exit code 100.

mk-build-deps wraps a call to apt-get install, but doesn't return the
exit code that apt-get returns when apt-get returns one. It makes it
hard to distinguish the error modes, but mk-build-deps is unlikely to
fail on anything else than apt-get. Not all apt-get failures would be
due to snapshot.debian.org availability, but that's a tradeoff we
decided was okay in bug 1486071.

Differential Revision: https://phabricator.services.mozilla.com/D22269

--HG--
extra : moz-landing-system : lando
  • Loading branch information...
glandium committed Mar 6, 2019
1 parent 4834d96 commit 7cb9cf0fa3b9c05ef1f901b8ba51bb121d4a8950
Showing with 2 additions and 2 deletions.
  1. +2 −2 taskcluster/taskgraph/transforms/job/debian_package.py
@@ -159,14 +159,14 @@ def docker_worker_debian_package(config, job, taskdesc):
'apt-get dist-upgrade && '
'cd /tmp && '
# Get, validate and extract the package source.
'dget -d -u {src_url} && '
'(dget -d -u {src_url} || exit 100) && '
'echo "{src_sha256} {src_file}" | sha256sum -c && '
'{unpack} && '
'cd {package} && '
# Optionally apply patch and/or pre-build command.
'{adjust}'
# Install the necessary build dependencies.
'mk-build-deps -i -r debian/control -t \'{resolver}\' && '
'(mk-build-deps -i -r debian/control -t \'{resolver}\' || exit 100) && '
# Build the package
'DEB_BUILD_OPTIONS="parallel=$(nproc) nocheck" dpkg-buildpackage && '
# Copy the artifacts

0 comments on commit 7cb9cf0

Please sign in to comment.
You can’t perform that action at this time.