Skip to content
Permalink
Branch: master
Commits on Mar 15, 2019
  1. Bug 1535501 - Allow to get full crashreporter symbols on artifact bui…

    glandium committed Mar 15, 2019
    …lds. r=mshal
    
    Differential Revision: https://phabricator.services.mozilla.com/D23605
    
    --HG--
    extra : moz-landing-system : lando
Commits on Mar 13, 2019
  1. Bug 1534522 - Add a build type for EME-enabled win64-aarch64. r=dmajor

    glandium committed Mar 13, 2019
    Depends on D23101
    
    Differential Revision: https://phabricator.services.mozilla.com/D23102
    
    --HG--
    extra : moz-landing-system : lando
  2. Bug 1534522 - Allow to specify different task ids for artifacts. r=dm…

    glandium committed Mar 13, 2019
    …ajor
    
    Bug 1528123 added a way to specify a task id to influence mach
    artifact. In the case of upcoming EME-enabled win64-aarch64 builds, we
    need to be able to specify two different task ids, which a single
    environment variable doesn't really allow.
    
    So extend the scheme to check environment variables with the build
    type included in the variable name.
    
    Differential Revision: https://phabricator.services.mozilla.com/D23101
    
    --HG--
    extra : moz-landing-system : lando
Commits on Mar 12, 2019
  1. Bug 1534500 - Run get_and_diffoscope with bash. r=dustin

    glandium committed Mar 12, 2019
    This will allow to use bash constructs in pre-diff-commands, like
    `{a,b}`.
    
    Depends on D23075
    
    Differential Revision: https://phabricator.services.mozilla.com/D23076
    
    --HG--
    extra : moz-landing-system : lando
  2. Bug 1534500 - Allow diffoscope tasks to run commands before running t…

    glandium committed Mar 12, 2019
    …he diff. r=dustin
    
    Depends on D23074
    
    Differential Revision: https://phabricator.services.mozilla.com/D23075
    
    --HG--
    extra : moz-landing-system : lando
  3. Bug 1534500 - Allow diffoscope tasks to work on unpacked builds. r=du…

    glandium committed Mar 12, 2019
    …stin
    
    Depends on D23073
    
    Differential Revision: https://phabricator.services.mozilla.com/D23074
    
    --HG--
    extra : moz-landing-system : lando
  4. Bug 1534500 - Allow to configure diffoscope tasks that fail when they…

    glandium committed Mar 12, 2019
    … detect differences. r=dustin
    
    Differential Revision: https://phabricator.services.mozilla.com/D23073
    
    --HG--
    extra : moz-landing-system : lando
  5. Bug 1534524 - Apply the changes from bug 1470502 to build-binutils.sh…

    glandium committed Mar 12, 2019
    …. r=dmajor
    
    Differential Revision: https://phabricator.services.mozilla.com/D23092
    
    --HG--
    extra : moz-landing-system : lando
  6. Bug 1513605 - Add PIC flags when running the clock_gettime(CLOCK_MONO…

    glandium committed Mar 12, 2019
    …TONIC) check. r=dmajor
    
    Differential Revision: https://phabricator.services.mozilla.com/D23091
    
    --HG--
    extra : moz-landing-system : lando
  7. Bug 1534381 - Adjust paths to match the jarlog on mac. r=chmanchester

    glandium committed Mar 12, 2019
    Differential Revision: https://phabricator.services.mozilla.com/D23065
    
    --HG--
    extra : moz-landing-system : lando
Commits on Mar 11, 2019
  1. Bug 1490573 - Use fetches for nsis and wine toolchain tasks. r=froydnj

    glandium committed Mar 11, 2019
    These toolchain tasks are the last ones using the historical
    download-tools script from build/unix/build-gcc, which invokes gpg to
    validate the downloaded tarballs. The consequence is that gpg-agent is
    spawned and stays running, preventing a cleanup script from doing its
    job, making the tasks fail.
    
    Fetches are the new way to download sources, and can also do gpg
    validation without those caveats.
    
    The download-tools.sh script can then be removed as it's not used
    anymore.
    
    Differential Revision: https://phabricator.services.mozilla.com/D22682
    
    --HG--
    extra : moz-landing-system : lando
  2. Bug 1533659 - Fix arguments handling in unpack.py after bug 1531634. …

    glandium committed Mar 11, 2019
    …r=froydnj
    
    Differential Revision: https://phabricator.services.mozilla.com/D22658
    
    --HG--
    extra : moz-landing-system : lando
Commits on Mar 8, 2019
  1. Bug 1531632 - Initialize environment variables before loading libxul.…

    glandium committed Mar 8, 2019
    … r=snorp
    
    There are at least two known side effects of initializing it after
    loading libxul:
    - We can't set LLVM_PROFILE_FILE for the instrumentation part of PGO to
      make the compiler-rt static initializer pick it.
    - We can't set MOZ_DEBUG_LINKER to enable the linker debug log (which
      used to work when environment variables were set earlier).
    
    Differential Revision: https://phabricator.services.mozilla.com/D21646
    
    --HG--
    extra : moz-landing-system : lando
Commits on Mar 7, 2019
  1. Bug 1529894 - Change jar log content. r=aklotz,chmanchester

    glandium committed Mar 7, 2019
    The jar log is used for optimization of the packaged jar files according
    to their usage patterns during a profile run. The current content of the
    file currently come with 2 caveats:
    - it contains entries for jar archives that aren't relevant to
      packaging, which is not a problem in itself, but see below.
    - it contains full paths for jar archives that may not correspond to the
      location of the packaged directory (on e.g. Android, where the build
      almost certainly doesn't happen in the same directory on the host as
      Fennec runs in the emulator/on the device).
    
    The current JarLog code does somehow handle the various ways paths are
    currently presented, but it's clearly missing code to map the paths in
    the log to packaged paths. Instead of requiring manual work and extra
    build options to handle this mapping, and considering the caveats above,
    it's just simpler to log archive paths as if they were relative to the
    packaged application directory in a build, and use that during
    packaging.
    
    Depends on D21655
    
    Differential Revision: https://phabricator.services.mozilla.com/D21656
    
    --HG--
    extra : moz-landing-system : lando
  2. Bug 1529894 - Change zip logging initialization. r=aklotz

    glandium committed Mar 7, 2019
    Instead of checking the MOZ_JAR_LOG_FILE for each log entry, only check
    it once, and only check whether to log once per archive rather than once
    per item.
    
    Differential Revision: https://phabricator.services.mozilla.com/D21655
    
    --HG--
    extra : moz-landing-system : lando
  3. Bug 1531632 - Initialize environment variables before loading libxul.…

    glandium committed Mar 7, 2019
    … r=snorp
    
    There are at least two known side effects of initializing it after
    loading libxul:
    - We can't set LLVM_PROFILE_FILE for the instrumentation part of PGO to
      make the compiler-rt static initializer pick it.
    - We can't set MOZ_DEBUG_LINKER to enable the linker debug log (which
      used to work when environment variables were set earlier).
    
    Differential Revision: https://phabricator.services.mozilla.com/D21646
    
    --HG--
    extra : moz-landing-system : lando
  4. Bug 1532883 - Remove nasm Debian packages. r=dustin

    glandium committed Mar 7, 2019
    Differential Revision: https://phabricator.services.mozilla.com/D22257
    
    --HG--
    extra : moz-landing-system : lando
  5. Bug 1532883 - Add missing configuration for nasm on hazard and plain …

    glandium committed Mar 7, 2019
    …builds. r=dmajor
    
    Differential Revision: https://phabricator.services.mozilla.com/D22451
    
    --HG--
    extra : moz-landing-system : lando
  6. Bug 1532878 - Install diffoscope from stretch-backports. r=dustin

    glandium committed Mar 7, 2019
    As of the update snapshot, stretch-backports contains version 112.
    
    Depends on D22264
    
    Differential Revision: https://phabricator.services.mozilla.com/D22265
    
    --HG--
    extra : moz-landing-system : lando
  7. Bug 1532878 - Update to a more recent snapshot for Debian stretch-bas…

    glandium committed Mar 7, 2019
    …ed docker images. r=dustin
    
    This has the side effect of addressing bug 1524723 for those images.
    
    Depends on D22263
    
    Differential Revision: https://phabricator.services.mozilla.com/D22264
    
    --HG--
    extra : moz-landing-system : lando
  8. Bug 1532878 - Ensure the base Debian docker image is up-to-date wrt t…

    glandium committed Mar 7, 2019
    …he snapshot used. r=dustin
    
    When the apt snapshot is more recent than the docker image on the docker
    hub, some packages may not be up-to-date.
    
    Depends on D22455
    
    Differential Revision: https://phabricator.services.mozilla.com/D22263
    
    --HG--
    extra : moz-landing-system : lando
  9. Bug 1532878 - Unbreak mach-o diffs after bug 1513798. r=dustin

    glandium committed Mar 7, 2019
    Depends on D22262
    
    Differential Revision: https://phabricator.services.mozilla.com/D22455
    
    --HG--
    extra : moz-landing-system : lando
  10. Bug 1532878 - Derive the diffoscope docker image from debian9-base. r…

    glandium committed Mar 7, 2019
    …=dustin
    
    Because the debian9-base apt configuration doesn't install recommended
    packages, we end up needing to install more packages than before. We
    could pass --install-recommended to apt-get, but that would make the
    image larger than it already was after the upcoming changes, because
    new versions of diffoscope come with more recommended dependencies.
    
    The side effect is that this makes the image much smaller than it used
    to be, while preserving all the useful recommended packages (we don't
    actually need all of them).
    
    Differential Revision: https://phabricator.services.mozilla.com/D22262
    
    --HG--
    extra : moz-landing-system : lando
Commits on Mar 6, 2019
  1. Bug 1532893 - Retry packages tasks when snapshot.debian.org doesn't r…

    glandium committed Mar 6, 2019
    …espond. r=dustin
    
    Bug 1486071 intended to fix this, but while the tasks are setup to
    restart on exit status 100, there are multiple failure cases where
    snapshot.debian.org doesn't respond and the exit status is not 100.
    
    One is dget, when downloading package sources from snapshot.debian.org.
    Eventually, those should move to fetch tasks, but in the meantime, we
    bubble up get errors with an exit code 100.
    
    mk-build-deps wraps a call to apt-get install, but doesn't return the
    exit code that apt-get returns when apt-get returns one. It makes it
    hard to distinguish the error modes, but mk-build-deps is unlikely to
    fail on anything else than apt-get. Not all apt-get failures would be
    due to snapshot.debian.org availability, but that's a tradeoff we
    decided was okay in bug 1486071.
    
    Differential Revision: https://phabricator.services.mozilla.com/D22269
    
    --HG--
    extra : moz-landing-system : lando
  2. Bug 1530908 - Don't use different mozconfigs for artifact builds. r=c…

    glandium committed Mar 6, 2019
    …hmanchester
    
    Artifact mozconfigs are not necessarily up-to-date wrt changes to the
    nightly mozconfigs, and all in all, shouldn't be much different from
    them.
    
    It's just better to use the nightly mozconfigs (or beta on beta, etc.)
    and make the mozconfigs themselves handle the few things that need to be
    different when the USE_ARTIFACT environment is set (which is now
    consistently set by taskcluster)
    
    This does have the side effect of turning builds that actually don't
    support artifact builds red when using --artifact on try, instead of
    having them silently not be artifact builds as currently happens.
    
    Depends on D21314
    
    Differential Revision: https://phabricator.services.mozilla.com/D21315
    
    --HG--
    extra : moz-landing-system : lando
  3. Bug 1532899 - Mask `Build tools` section from about:buildconfig when …

    glandium committed Mar 6, 2019
    …all it can display is "None". r=froydnj
    
    Differential Revision: https://phabricator.services.mozilla.com/D22261
    
    --HG--
    extra : moz-landing-system : lando
  4. Bug 1530908 - Always set USE_ARTIFACT from taskcluster for artifact b…

    glandium committed Mar 6, 2019
    …uilds. r=chmanchester
    
    The artifact builds that are automatically derived using the artifact
    template set the USE_ARTIFACT environment variable from taskcluster.
    After the previous change, --artifact builds from try syntax do that
    too.
    That leaves us with only the artifact-build build not doing it, so for
    consistency, do it there. That makes it not necessary to set
    USE_ARTIFACT from mozconfig.artifact.automation anymore.
    
    Depends on D22056
    
    Differential Revision: https://phabricator.services.mozilla.com/D21313
    
    --HG--
    extra : moz-landing-system : lando
  5. Bug 1530908 - Only enable artifacts on try builds that support them. …

    glandium committed Mar 6, 2019
    …r=dustin
    
    Currently, all tasks of kind builds are indiscriminately altered to use
    artifacts, but only few of them actually support that, and the others
    won't actually have the expected result when that happens. E.g. ASAN
    builds with artifacts enabled end up being non-ASAN builds.
    
    Effectively, this makes the artifact flag ignored for builds that don't
    support artifacts. One could argue that those builds shouldn't happen at
    all, but it feels a better use time of developer's time to just do the
    full build they asked for. E.g. if they asked for ASAN with artifacts,
    they still get an ASAN build, rather than an error or silently having
    the task not happen after the decision task. This also allows to mix
    artifact and non-artifact builds.
    
    Further changes down the road are also modifying the artifact builds
    configuration, which would actively turn those builds that don't support
    artifact builds red (e.g. ASAN), so something has to be done anyways.
    The alternative would be filter those builds out.
    
    Depends on D21312
    
    Differential Revision: https://phabricator.services.mozilla.com/D22056
    
    --HG--
    extra : moz-landing-system : lando
  6. Bug 1530908 - Unify artifact builds setup between try config and try …

    glandium committed Mar 6, 2019
    …syntax. r=dustin
    
    While try syntax is approaching its EOL, the fact that using it to do
    artifact builds does some things subtly differently from using try
    config is not helpful.
    
    Depends on D22055
    
    Differential Revision: https://phabricator.services.mozilla.com/D21312
    
    --HG--
    extra : moz-landing-system : lando
  7. Bug 1530908 - Move list of supported artifact builds to an importable…

    glandium committed Mar 6, 2019
    … module. r=chmanchester
    
    Depends on D22054
    
    Differential Revision: https://phabricator.services.mozilla.com/D22055
    
    --HG--
    extra : moz-landing-system : lando
  8. Bug 1530908 - Use an environment variable to enable LTO on automation…

    glandium committed Mar 6, 2019
    …. r=chmanchester
    
    This allows to disable it more easily for artifact builds.
    
    Differential Revision: https://phabricator.services.mozilla.com/D21311
    
    --HG--
    extra : moz-landing-system : lando
Commits on Mar 5, 2019
  1. Bug 1530600 - Fail to package if a jarlog was given but it contains n…

    glandium committed Mar 5, 2019
    …o data for omnijars. r=chmanchester
    
    Differential Revision: https://phabricator.services.mozilla.com/D21657
    
    --HG--
    extra : moz-landing-system : lando
  2. Bug 1529194 - Allow to opt-in to widevine on aarch64 Windows. r=firef…

    glandium committed Mar 5, 2019
    …ox-build-system-reviewers,chmanchester
    
    This uses artifacts from a win32 build to get the necessary DLLs.
    
    Differential Revision: https://phabricator.services.mozilla.com/D20597
    
    --HG--
    extra : moz-landing-system : lando
  3. Bug 1530908 - Move --enable-artifact-build-symbols to mozconfig.artif…

    glandium committed Mar 5, 2019
    …act. r=chmanchester
    
    Depends on D21313
    
    Differential Revision: https://phabricator.services.mozilla.com/D21314
    
    --HG--
    extra : moz-landing-system : lando
  4. Bug 1530908 - Use a transform for try --artifact instead of a morph. …

    glandium committed Mar 5, 2019
    …r=tomprince
    
    While the morph was changing the treeherder symbol to `Ba` for all jobs,
    doing so with a transform fails because of the conflicting symbol check
    (as multiple jobs in the same category would end up with `Ba`). So
    instead, we append `a` to the existing symbol.
    
    We also change the documentation wrt templates for try pushes, as the
    artifact template is now essentially gone (although technically, mach
    try will still set params['templates']['artifacts']['enabled'] for now,
    and the template still exists, albeit empty).
    
    Differential Revision: https://phabricator.services.mozilla.com/D22054
    
    --HG--
    extra : moz-landing-system : lando
You can’t perform that action at this time.