/moz/addon/install command regression: "data did not match any variant of untagged enum Helper"

[barancev]

System

• Version: 0.22
• Platform: Windows
• Firefox: Nightly 64.0a1 (2018-09-20) (64-bit)
• Selenium: HEAD

Trace-level log

0.22 trace log:

1537532269894	webdriver::server	DEBUG	-> POST /session/ff9a2565-6cd5-4442-b86d-0bdc3c0ac9dd/moz/addon/install {
  "path": "c:\\Temp\\search_encrypt-2.8.3-an+fx.xpi"
}
1537532269895	webdriver::server	DEBUG	<- 400 Bad Request {"value":{"error":"invalid argument","message":"data did not match any variant of untagged enum Helper","stacktrace":""}}

0.21 trace log:

1537527046406	webdriver::server	DEBUG	-> POST /session/3f70bc2e-cde0-4326-bee8-310df0708a95/moz/addon/install {
  "path": "c:\\Temp\\search_encrypt-2.8.3-an+fx.xpi"
}
1537527047014	Marionette	TRACE	0 -> [0,2,"Addon:Install",{"path":"c:\\Temp\\search_encrypt-2.8.3-an+fx.xpi","temporary":false}]
1537527052973	Marionette	TRACE	0 <- [1,2,null,{"value":"@searchencrypt"}]
1537527052974	webdriver::server	DEBUG	<- 200 OK {"value":"@searchencrypt"}

[andreastt]

I suppose we don’t use this endpoint in our internal infrastructure, as the test harnesses who need to install web extensions speak to Marionette directly. It’s unfortunate that we’e not dogfooding this endpoint, as we likely would have caught this regression.

@whimboo Can you look at this? I guess maybe one of the parameters is not optional or something?

[andreastt]

I suppose we don’t use this endpoint in our internal infrastructure, as the test harnesses who need to install web extensions speak to Marionette directly. It’s unfortunate that we’e not dogfooding this endpoint, as we likely would have caught this regression.

@whimboo Can you look at this? I guess maybe one of the parameters is not optional or something?

[whimboo]

It's a regression with the Serde changes, and I ask @barancev to file a bug. He is also going to do that soon. Please let us know here once it has been done. Thanks.

[whimboo]

It's a regression with the Serde changes, and I ask @barancev to file a bug. He is also going to do that soon. Please let us know here once it has been done. Thanks.

[barancev]

https://bugzilla.mozilla.org/show_bug.cgi?id=1493149

[barancev]

https://bugzilla.mozilla.org/show_bug.cgi?id=1493149

[whimboo]

This is fixed and will be part of the next release of geckodriver.

[whimboo]

This is fixed and will be part of the next release of geckodriver.