New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go back not working #815
Comments
Firefox 53 is fairly old and we have made a number of improvements to the Go Back command since then. Can you please try again with Firefox Nightly? |
Tried using firefox 54 and had the same issues there. I am running my tests from a selenium node that is hosted remotely and I am not entirely sure how to make the tests run on the nightly build as it is installed as a seperate executable instead of replacing my old firefox. Is there a way to specify the path of firefox in the node config in selenium or some other trick to be able to test this in the nightly build? |
Firefox 54 is stable. Could you test with Firefox 56 (Nightly)? It would also be good if you attached a trace-level log from geckodriver. See the README for how to configure a specific Firefox binary through capabilities. |
Seems to have the exact same issue on the nightly build.
After doing some visual inspection I can see that the browser does in fact navigate back, but it seems to timeout once it's done navigating back |
And the trace log? |
That there was the trace log after the |
That log line doesn’t originate from geckodriver, but from Selenium. To have any chance at diagnosing this issue, you need to provide a trace-level log from geckodriver. See the README for how to configure it. You can either pass |
I couldn't find out how to make selenium pass the
|
This is a debug log but not a trace log. Can you please show the code how you selected the trace option? Also please show the line of code which navigates back. |
Here is the code where I initialize the webdriver
Here is the part of the test with the back navigation
I assumed everything was in order since the first line printed when running the tests is |
Strange. Not sure why this doesn't give trace level logs. @andreastt knows more about that, and maybe he can help. Regarding navigating back, how is |
Source code should be here: https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/lib/webdriver.js#L1151 It's working for the other browsers we are currently testing on (Edge,Chrome,mobile chrome) |
Ok, so this looks fine. But what I find strange is that debug events from Marionette show up in your log, but nothing appears for 'goBack'. Given that I cannot access this website, can you please check if it is using some framework? I wonder if it could be related to issue #697, which is about Turbolinks. |
I am not that technically involved in the development of our site, but AFAIK we're not using any specific framework that should affect anything here. However when looking at #697 I can confirm that we do not fire any pagehide or pageload events when navigating back and forth through our application. I guess you can merge this issue with #697 if you require these events to be fired in order to resolve a goBack |
I see. But it might still be something else. So is this behavior only visible for the development version of the website? Or can someone also see this for the public version? If yes, it would be great if you can construct a minimal Selenium testcase which let me reproduce it. |
We don't have a production version of the website I am writing tests for right now, but we have another production site with the same issue that I could send you a link to. http://nrk.no/valg/2017/valgomat
The test times out on the |
@whimboo Have you been able to try this and see whether or not you are able to get more trace information than what I got? |
Given that I was out the last 2 weeks I wasn't able to check this issue again. So lets see... First, thanks a lot for this test case! It is pretty helpful for me to reproduce this problem. I'm not sure what's going on so I filed a bug for Marionette here: https://bugzilla.mozilla.org/show_bug.cgi?id=1386977. Hopefully we will have a solution for this problem soon. |
@metareven, is this website using the react library from Facebook (https://facebook.github.io/react/)? |
@whimboo Yes this page uses react |
Thanks! I will update the issue when the bug gets solved. |
This is fixed now and will be available in the Nightly build of Firefox today. |
It works! |
This feature just got uplifted and should be part of the next 56 beta. |
This issue has been automatically locked since there has not been any recent activity after it was closed. If you have run into an issue you think is related, please open a new issue. |
Platform and application details
Whenever I try to use browser.navigate().back() on the javascript selenium bindings the test case times out with the following stack trace:
It works on every other browser I have tried, including Internet Explorer
The text was updated successfully, but these errors were encountered: