New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-compile on win32 using Docker image from port-of-rust #213

Merged
merged 1 commit into from Sep 6, 2016

Conversation

Projects
None yet
3 participants
@jgraham
Collaborator

jgraham commented Sep 5, 2016

This change is Reviewable

@jgraham

This comment has been minimized.

Collaborator

jgraham commented Sep 5, 2016

@andreastt

This comment has been minimized.

Member

andreastt commented Sep 6, 2016

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


.travis.yml, line 6 [r1] (raw file):

    - $HOME/.cargo
    - $TRAVIS_BUILD_DIR/target
    - /home/travis/docker/

Can be $HOME/travis/docker like the above $HOME/.cargo line, but not essential.


ci.sh, line 8 [r1] (raw file):

    tag="port-of-rust/$TARGET/latest"
    docker build https://github.com/alexcrichton/port-of-rust.git -f "$TARGET/Dockerfile" -t $tag
    docker run -e USER="$USER" -e TARGET="$TARGET" -e USE_DOCKER=1 -e NAME="$NAME" -e TRAVIS_TAG="$TRAVIS_TAG" -e USER_ID=$(id -u) -e GROUP_ID=$(id -g) -v $PWD:/mnt/host -v $PWD:/mnt/host -i $tag bash -s -- < build.sh

I think it would be beneficial for readability to break this up into multiple lines.


Comments from Reviewable

@jgraham jgraham force-pushed the win32_docker branch from d64a6fb to 994cb31 Sep 6, 2016

@andreastt

This comment has been minimized.

Member

andreastt commented Sep 6, 2016

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@andreastt andreastt merged commit 39b2b26 into master Sep 6, 2016

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
code-review/reviewable 3 files reviewed
Details
@timaharrison

This comment has been minimized.

timaharrison commented Sep 7, 2016

Please accept my apologies if this isn't the right place to ask but I don't know where else is. I'm not a developer, but a user of Firefox and Selenium.
Issues 138 and 146 have been merged in to this one, and I was tracking one of these, about geckodriver for 32bit windows.
I understand that there are difficulties with creating 32bit versions for the Geckodriver, but the situation at the moment is that none of my tests can be run on Firefox, since the original Firefox Driver became obsolete in June. It is not feasible to change to windows 64bit, nor can I start using old versions of Firefox. I'm sure that many users all over the globe are in the same position unless I'm missing something (please say if I am)
Please can someone say if there is going to be a version for 32bit that works with the most recent Firefox, and if so when we can expect it.
Thanks

@andreastt

This comment has been minimized.

Member

andreastt commented Sep 7, 2016

@timaharrison We have finished the work to make Windows 32-bit compilation possible in geckodriver’s continuous integration. We have not released a new version yet. You can track the progress of the next release, which will include a 32-bit Windows binary, in https://github.com/mozilla/geckodriver/milestone/1.

@whimboo whimboo deleted the win32_docker branch Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment