Disable additional welcome URL #222

Merged
merged 3 commits into from Sep 12, 2016

Projects

None yet

2 participants

@andreastt
Member
andreastt commented Sep 8, 2016 edited

The preference startup.homepage_welcome_url.additional causes problems with official branded builds that has been known to break certain Marionette tests, such as testing/marionette/harness/marionette/tests/unit/test_window_handles.py and testing/marionette/harness/marionette/tests/unit/test_selected.py.

Many Marionette tests make assumptions about the number of open windows, and this aligns the test environment of the officially branded builds to be more similar to that of Nightly builds.

Fixes #80.


This change is Reviewable

@andreastt andreastt disable additional welcome URL
The preference startup.homepage_welcome_url.additional causes problems with
official branded builds that has been known to break certain Marionette tests,
such as testing/marionette/harness/marionette/tests/unit/test_window_handles.py
and testing/marionette/harness/marionette/tests/unit/test_selected.py.

Many Marionette tests make assumptions about the number of open windows, and
this aligns the test environment of the officially branded builds to be more
similar to that of Nightly builds.
d6922b7
@jgraham
Collaborator
jgraham commented Sep 8, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


src/marionette.rs, line 103 [r1] (raw file):

        ("signon.autofillForms", Pref::new(false)),
        ("signon.rememberSignons", Pref::new(false)),
        ("startup.homepage_welcome_url", Pref::new("about:blank")),

Why did this change? I expect these are equivalent, but the empty string is less clear.


Comments from Reviewable

@jgraham
Collaborator
jgraham commented Sep 8, 2016

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

andreastt added some commits Sep 9, 2016
@andreastt andreastt fixup! disable additional welcome URL
46c52b5
@andreastt andreastt fixup! disable additional welcome URL
db107c4
@andreastt
Member

Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/marionette.rs, line 103 [r1] (raw file):

Previously, jgraham wrote…

Why did this change? I expect these are equivalent, but the empty string is less clear.

I used what is in [geckoinstance.py](https://github.com/mozilla/gecko-dev/blame/master/testing/marionette/client/marionette_driver/geckoinstance.py), but I guess "about:blank" is clearer.

Comments from Reviewable

@jgraham
Collaborator
jgraham commented Sep 12, 2016

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jgraham jgraham merged commit c49e5cd into mozilla:master Sep 12, 2016

2 checks passed

code-review/reviewable 1 file reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment