Add --webdriver-port argument back as a hidden alias #235

Merged
merged 1 commit into from Sep 21, 2016

Projects

None yet

2 participants

@andreastt
Member
andreastt commented Sep 21, 2016 edited

Unfortunately clap does not seem to have an alias method on clap::Arg, but this does the trick.


This change is Reviewable

@andreastt
Member
@andreastt andreastt assigned andreastt and unassigned andreastt Sep 21, 2016
@jgraham
Collaborator
jgraham commented Sep 21, 2016

Please update the commit message to indicate why we are doing this.


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@andreastt andreastt add --webdriver-port argument back as a hidden alias
geckodriver recently removed this command line argument and broke a
number of consumers, including infrastructure code at Google.  This patch
rectifies the change by providing `--webdriver-port` as an alias to
`--port`.

Because this option was changed from something quite specific to
less specific, it should be non-controversial to add an alias in that
direction, wher esomething more-specific maps to someting less-specific.
d470973
@andreastt andreastt merged commit 72c4a05 into mozilla:master Sep 21, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
code-review/reviewable 2 files reviewed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment