Bug 1734879 - Accept arch and os version as init params on Qt #825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we discussed making these values enums maybe, but for os version that is just not possible and for architecture that would be hard, see https://doc.qt.io/qt-5/qsysinfo.html#currentCpuArchitecture, we don't have a list of all the possible values returned by the Qt function that retrieves that value.
I think this is fine though, because different from what we thought yesterday, GLAM does not use the architecture field for creating filters, it uses only OS and channel.
Pull Request checklist
glean/
folder, run:npm run test
Runs all testsnpm run lint
Runs all lintersTests: This PR includes thorough tests or an explanation of why it does notCHANGELOG.md
or an explanation of why it does not need onemozilla/glean
repository