Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1734879 - Accept arch and os version as init params on Qt #825

Merged
merged 2 commits into from Oct 12, 2021

Conversation

brizental
Copy link
Member

I know we discussed making these values enums maybe, but for os version that is just not possible and for architecture that would be hard, see https://doc.qt.io/qt-5/qsysinfo.html#currentCpuArchitecture, we don't have a list of all the possible values returned by the Qt function that retrieves that value.

I think this is fine though, because different from what we thought yesterday, GLAM does not use the architecture field for creating filters, it uses only OS and channel.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from badboy October 12, 2021 10:49
glean/src/core/config.ts Outdated Show resolved Hide resolved
@brizental brizental merged commit c093058 into mozilla:main Oct 12, 2021
@brizental brizental deleted the 1734879-qt-arch-os branch October 12, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants