Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1741581 - Attempt to get virtualenv name from environment #965

Merged
merged 2 commits into from Nov 18, 2021

Conversation

brizental
Copy link
Member

@brizental brizental commented Nov 18, 2021

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from mdboom November 18, 2021 09:45
@brizental brizental requested review from Dexterp37 and removed request for mdboom November 18, 2021 09:47
glean/src/cli.ts Show resolved Hide resolved
@brizental brizental merged commit e6e9272 into mozilla:main Nov 18, 2021
@brizental brizental deleted the 1741581-use-existing-venv branch November 18, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants