Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1649925 - Ensure Glean does not initialize with an empty application id #1043

Merged
merged 1 commit into from Jul 8, 2020

Conversation

Dexterp37
Copy link
Collaborator

@Dexterp37 Dexterp37 commented Jul 8, 2020

Using an empty application id makes it impossible to upload pings to ingestion, since the application id is used to build the submission path. This makes sure the error is caught instead of just silently failing to upload pings.

@Dexterp37 Dexterp37 requested a review from badboy Jul 8, 2020
@Dexterp37 Dexterp37 self-assigned this Jul 8, 2020
@auto-assign auto-assign bot requested a review from travis79 Jul 8, 2020
@Dexterp37 Dexterp37 removed the request for review from travis79 Jul 8, 2020
Using an empty application id makes it impossible to upload pings
to ingestion, since the application id is used to build the submission
path.
badboy
badboy approved these changes Jul 8, 2020
@Dexterp37 Dexterp37 merged commit 202fc44 into mozilla:main Jul 8, 2020
32 of 33 checks passed
@Dexterp37 Dexterp37 deleted the fix_empty_appid branch Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants