Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1653244 - Fix experiment info getting cleared before getting into metrics ping #1069

Merged
merged 2 commits into from Jul 20, 2020

Conversation

travis79
Copy link
Member

@travis79 travis79 commented Jul 17, 2020

This is the fix for the Android/Kotlin bindings and a modified test to cover the case.

@auto-assign auto-assign bot requested a review from brizental Jul 17, 2020
Copy link
Contributor

@mdboom mdboom left a comment

LGTM -- but maybe this one especially should have @Dexterp37's eye given the metrics ping scheduler involvement?

Does Swift also suffer the same issue and should we file a bug to do that work?

@travis79
Copy link
Member Author

travis79 commented Jul 17, 2020

LGTM -- but maybe this one especially should have @Dexterp37's eye given the metrics ping scheduler involvement?

Does Swift also suffer the same issue and should we file a bug to do that work?

Swift, fortunately, does not suffer from this so nothing to change there. This appeared to be an Android only issue, and only since init was made async.

Copy link
Collaborator

@Dexterp37 Dexterp37 left a comment

Looks good overall. Holding back r+ because of the changelog: I'd love to take a look at that before merging.

@@ -201,10 +201,10 @@ internal class MetricsPingScheduler(
if (isDifferentVersion()) {
Copy link
Collaborator

@Dexterp37 Dexterp37 Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry for this!

@@ -510,10 +511,15 @@ class MetricsPingSchedulerTest {
val expectedValue = "canary"
expectedStringMetric.set(expectedValue)

// Set an experiment active to verify it gets sent in the pings
Glean.setExperimentActive("test-experiment", "a")
Copy link
Collaborator

@Dexterp37 Dexterp37 Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be an integration test for our sample app, along with most of the tests in this file. Nothing you can do here, though - this whole thing would require its own bug. @travis79 would you kindly file it?

Copy link
Member Author

@travis79 travis79 Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… metrics ping

This is the fix for the Android/Kotlin bindings and a modified test to cover the case.
Fix wording
@travis79 travis79 merged commit 8bb8e49 into mozilla:main Jul 20, 2020
32 of 33 checks passed
@travis79 travis79 deleted the Bug1653244 branch Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants