Bug 1601550 - Enforce disk quota on pending pings directory #1110
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The test was not checking if pings were actually loadedfrom disk
The problem was that the test was trying to get a request sent by a worker, but that worker received a PingUploadTask::Wait before getting a PingUploadTask::Upload and the test was trying to check the request before it had actually arrived. This is potentially an issue with more tests, but it only manifested in this test for now. I opened Bug 1657589 for more in depth investigation on this.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.