Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1644364 - Move logic to limit max retries on recoverable failures to glean-core #1120

Merged
merged 8 commits into from Aug 4, 2020

Conversation

brizental
Copy link
Member

@brizental brizental commented Aug 3, 2020

No description provided.

@auto-assign auto-assign bot requested a review from Dexterp37 Aug 3, 2020
glean-core/src/upload/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Looks nice overall, this is a good improvement!

glean-core/src/upload/mod.rs Outdated Show resolved Hide resolved
glean-core/src/upload/mod.rs Outdated Show resolved Hide resolved
glean-core/src/upload/mod.rs Outdated Show resolved Hide resolved
glean-core/csharp/Glean/Net/BaseUploader.cs Show resolved Hide resolved
glean-core/python/tests/test_network.py Show resolved Hide resolved
glean-core/src/upload/mod.rs Outdated Show resolved Hide resolved
brizental added 6 commits Aug 4, 2020
* period -> uploading window;
* get_upload_task_job -> get_upload_task_internal;
* Add comment to all bindings on how we avoind infinite loops;
* Correct position of incoming task comment in Kt;
* Add CHANGELOG.md entry;
@brizental brizental force-pushed the 1644364-limit-max-retries branch from 2bfcc25 to 0af1433 Compare Aug 4, 2020
@brizental brizental requested a review from Dexterp37 Aug 4, 2020
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

r+ with the changelog update!

CHANGELOG.md Show resolved Hide resolved
@brizental brizental merged commit 78bee73 into mozilla:main Aug 4, 2020
26 of 27 checks passed
@brizental brizental deleted the 1644364-limit-max-retries branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants