Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to UniFFI 0.23 #2338

Merged
merged 2 commits into from Jan 30, 2023
Merged

Update to UniFFI 0.23 #2338

merged 2 commits into from Jan 30, 2023

Conversation

badboy
Copy link
Member

@badboy badboy commented Jan 17, 2023

This adopts the new crate layout and only directly depends on the uniffi crate.
Everything else is a transitive dependency. This hopefully reduces the amount of churn and coordination needed when uniffi_* crates are updated.


v0.23 is not yet released. This currently uses it from the git repository.

@badboy badboy marked this pull request as ready for review January 30, 2023 11:45
@badboy badboy requested a review from a team as a code owner January 30, 2023 11:45
@badboy badboy requested review from chutten and removed request for a team January 30, 2023 11:45
@badboy badboy force-pushed the uniffi-0.23 branch 4 times, most recently from d64fd1a to 0c3bdd7 Compare January 30, 2023 12:28
@badboy badboy enabled auto-merge (rebase) January 30, 2023 12:44
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 28.57% // Head: 28.57% // No change to project coverage 👍

Coverage data is based on head (0c3bdd7) compared to base (c3bee00).
Patch has no changes to coverable lines.

❗ Current head 0c3bdd7 differs from pull request most recent head d68446f. Consider uploading reports for the commit d68446f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2338   +/-   ##
=======================================
  Coverage   28.57%   28.57%           
=======================================
  Files           1        1           
  Lines          35       35           
=======================================
  Hits           10       10           
  Misses         25       25           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

This adopts the new crate layout and only directly depends on the
`uniffi` crate.
Everything else is a transitive dependency. This hopefully reduces the
amount of churn and coordination needed when uniffi_* crates are updated.
Also upgrades the images in use on CI
@badboy badboy merged commit d86acb0 into main Jan 30, 2023
@badboy badboy deleted the uniffi-0.23 branch January 30, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants