Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the LifecycleEventObserver API #501

Merged
merged 2 commits into from Nov 20, 2019
Merged

Conversation

@mdboom
Copy link
Collaborator

mdboom commented Nov 20, 2019

This doesn't require annotations or any Java8 magic, so hopefully will work.

This doesn't require annotations or any Java8 magic, so hopefully will work.
@mdboom mdboom requested review from badboy, Dexterp37 and travis79 as code owners Nov 20, 2019
Copy link
Collaborator

Dexterp37 left a comment

Looks good to me. Please make sure our integration tests work before merging.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #501 into master will decrease coverage by 0.02%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #501      +/-   ##
============================================
- Coverage     76.56%   76.54%   -0.03%     
- Complexity      332      333       +1     
============================================
  Files            96       96              
  Lines          5607     5606       -1     
  Branches        652      652              
============================================
- Hits           4293     4291       -2     
  Misses          832      832              
- Partials        482      483       +1
Impacted Files Coverage Δ Complexity Δ
...elemetry/glean/scheduler/GleanLifecycleObserver.kt 100% <100%> (ø) 4 <4> (+1) ⬆️
.../telemetry/glean/scheduler/MetricsPingScheduler.kt 95% <57.14%> (-1.35%) 27 <2> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a995c2c...41e9ec8. Read the comment docs.

@mdboom mdboom merged commit 711e023 into mozilla:master Nov 20, 2019
19 checks passed
19 checks passed
ci/circleci: Android tests Your tests passed on CircleCI!
Details
ci/circleci: C tests Your tests passed on CircleCI!
Details
ci/circleci: Check Rust formatting Your tests passed on CircleCI!
Details
ci/circleci: Check Swift formatting Your tests passed on CircleCI!
Details
ci/circleci: Generate Kotlin documentation Your tests passed on CircleCI!
Details
ci/circleci: Generate Python documentation Your tests passed on CircleCI!
Details
ci/circleci: Generate Rust documentation Your tests passed on CircleCI!
Details
ci/circleci: Lint Android with ktlint and detekt Your tests passed on CircleCI!
Details
ci/circleci: Lint Python Your tests passed on CircleCI!
Details
ci/circleci: Lint Rust with clippy Your tests passed on CircleCI!
Details
ci/circleci: Lint YAML with yamllint Your tests passed on CircleCI!
Details
ci/circleci: Python tests Your tests passed on CircleCI!
Details
ci/circleci: Rust FFI header check Your tests passed on CircleCI!
Details
ci/circleci: Rust code coverage Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - minimum version Your tests passed on CircleCI!
Details
ci/circleci: Rust tests - stable Your tests passed on CircleCI!
Details
ci/circleci: docs-linkcheck Your tests passed on CircleCI!
Details
ci/circleci: iOS build and test Your tests passed on CircleCI!
Details
ci/circleci: iOS integration test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.