Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1628057: Include app lifetime metrics in dirty_startup baseline pings #810

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Apr 7, 2020

TODO:

  • Port to iOS.

@mdboom mdboom requested a review from travis79 Apr 7, 2020
@auto-assign auto-assign bot requested a review from brizental Apr 7, 2020
@mdboom mdboom force-pushed the sent-app-lifetime-metrics-in-baseline-dirty-startup branch from 0cf9909 to 6acfa00 Compare Apr 7, 2020
@badboy badboy removed the request for review from brizental Apr 8, 2020
@badboy
Copy link
Member

@badboy badboy commented Apr 8, 2020

I ported it to iOS and pushed to my own fork: badboy@1806d57

You should be able to pull that commit (I can't push to your repository)

@badboy
Copy link
Member

@badboy badboy commented Apr 8, 2020

Oh and we should land #811 first and then update the changelog here.

@mdboom mdboom force-pushed the sent-app-lifetime-metrics-in-baseline-dirty-startup branch from 6acfa00 to 1806d57 Compare Apr 8, 2020
@mdboom mdboom force-pushed the sent-app-lifetime-metrics-in-baseline-dirty-startup branch from 1806d57 to 5454e41 Compare Apr 8, 2020
Copy link
Member

@travis79 travis79 left a comment

LGTM!

lifetime: .application,
disabled: false
)
stringMetric.set("HELLOOOOO!")
Copy link
Member

@travis79 travis79 Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@mdboom mdboom merged commit 4292275 into mozilla:master Apr 8, 2020
27 checks passed
@mdboom mdboom deleted the sent-app-lifetime-metrics-in-baseline-dirty-startup branch Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants