Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new flag `sendIfEmpty` for pings #139

Merged
merged 3 commits into from Nov 27, 2019
Merged

Added a new flag `sendIfEmpty` for pings #139

merged 3 commits into from Nov 27, 2019

Conversation

@badboy
Copy link
Member

badboy commented Nov 26, 2019

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to HISTORY.rst or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly
@badboy badboy force-pushed the send-if-empty branch from 8cc3913 to 2857927 Nov 26, 2019
@badboy badboy requested review from Dexterp37 and mdboom Nov 26, 2019
Copy link
Collaborator

Dexterp37 left a comment

Weird, I would have expected some tests to fail for this.

glean_parser/schemas/pings.1-0-0.schema.yaml Outdated Show resolved Hide resolved
glean_parser/schemas/pings.1-0-0.schema.yaml Outdated Show resolved Hide resolved
Copy link
Member

travis79 left a comment

r+ with @Dexterp37's nits addressed

badboy and others added 2 commits Nov 26, 2019
Co-Authored-By: Alessio Placitelli <alessio.placitelli@gmail.com>
@badboy badboy merged commit 4942d35 into master Nov 27, 2019
2 checks passed
2 checks passed
ci/circleci: build-37 Your tests passed on CircleCI!
Details
ci/circleci: build-38 Your tests passed on CircleCI!
Details
@badboy badboy deleted the send-if-empty branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.