go_server: unify logging and Pub/Sub behind a transport option#849
Merged
Conversation
akkomar
approved these changes
Jun 2, 2026
akkomar
left a comment
akkomar
left a comment
Member
There was a problem hiding this comment.
LGTM, this will make migration easier. Holding off merging until @tanfarming tests on his side.
Member
|
Can you give the PR a proper title so we know what this is about? |
Member
|
Same for the commit descriptions btw. |
badboy
reviewed
Jun 4, 2026
tanfarming
changed the title
tanfarming
force-pushed
the
ads/go_server_combined
branch
3 times, most recently
from
691be28 to
9568e2f
Compare
Contributor
Author
…tion
- Replace the go_server_pubsub outputter (shipped in 19.2.0) with a
`transport` option on the existing go_server outputter, with three
modes:
- `-s transport=logging`: stdout MozLog (default, unchanged behavior)
- `-s transport=pubsub`: Pub/Sub message builder
- `-s transport=combined`: both in one file, sharing common types
- The combined mode lets the one known 19.2.0 consumer migrate
incrementally without running two parallel build pipelines.
- Add an optional `DocumentID` field on each ping params struct. If set,
it is used as the ping's `document_id`; otherwise a fresh UUID is
generated. Set the same `DocumentID` on a params value passed to both
`RecordXxxPing` and `BuildXxxMessage` to share an ID across transports
during dual-write verification.
- Extract per-ping payload assembly into a shared
`(p XxxPing).buildPayload(...)` helper so the logging and Pub/Sub
code paths share one source of truth for metrics-map / events-slice
construction.
- BREAKING: the go_server_pubsub outputter is removed; callers must
switch to `--format go_server -s transport=pubsub`.
tanfarming
force-pushed
the
ads/go_server_combined
branch
from
9568e2f to
b3d4689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one