Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 654355 Multiple Client Match Rules #3

Merged
merged 3 commits into from Jul 9, 2011

Conversation

Projects
None yet
2 participants
Owner

Osmose commented Jun 28, 2011

Changes client match rules such that any inclusion rule that doesn't match a client causes the associated snippet to not be sent to the client.

This lets us scale by using a small set of rules and composing them together on snippets to limit which clients get which snippets.

Osmose added some commits Jun 28, 2011

# There's an include rule that doesn't match. Add it as an exclude rule so that...

(something like that)

And what should happen if they don't?

I really hate these tests (not your fault, of course). They're terribly brittle, as you can see from how much you had to change. Wouldn't it be better to just loop over the cache log and assert there are no sets?

@Osmose Osmose pushed a commit that referenced this pull request Jul 9, 2011

Michael Kelly Merge pull request #3 from Osmose/bug-654355-multi-rule
Bug 654355 Multiple Client Match Rules
ee8a598

@Osmose Osmose merged commit ee8a598 into mozilla:master Jul 9, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment