Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Three.js for better performance #5414

Closed
takahirox opened this issue May 6, 2022 · 4 comments · Fixed by #5488
Closed

Upgrade Three.js for better performance #5414

takahirox opened this issue May 6, 2022 · 4 comments · Fixed by #5488
Assignees
Labels
enhancement work that enhances an existing feature optimization

Comments

@takahirox
Copy link
Contributor

Is your feature request related to a problem? Please describe.

getProgramCacheKey() in Three.js seems to be one of the performance bottlenecks.

unknown

Describe the solution you'd like

The performance of it seems to be improved in r136. Maybe worth to upgrade our Three.js to the latest

mrdoob/three.js#22960

Additional context

Three.js we use now is r133 based

@takahirox takahirox added enhancement work that enhances an existing feature optimization labels May 6, 2022
@blairmacintyre
Copy link

Just talked with Rik about issues I'm having on Quest2, and he pointed to some fixes in 137 that will help perf (multisampling and layers) and solve my issues (custom shader related).

I too am wondering if upgrading is feasible.

@takahirox takahirox self-assigned this May 23, 2022
@takahirox
Copy link
Contributor Author

Status: I'm working on upgrading Three.js but encountered some weird problem on compilation with npm run dev.

@takahirox
Copy link
Contributor Author

@blairmacintyre Still a bit at testing phase but I made a PR #5488 . You can locally merge and test.

@blairmacintyre
Copy link

@takahirox I'm not sure I can test this; it's against the main branch of the hubs client, but we're using the hubs-cloud branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement work that enhances an existing feature optimization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants