Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

three part locales not supported #24

Open
shane-tomlinson opened this Issue Feb 26, 2013 · 3 comments

Comments

Projects
None yet
4 participants
Member

shane-tomlinson commented Feb 26, 2013

Windows 8 uses zh-Hans-CN for simplified chinese. Abide only attempts a single split on "-".

Link to mozilla/browserid#3044

@ghost ghost assigned callahad Feb 26, 2013

Member

ozten commented Mar 6, 2013

AMO's zamboni code properly handles this locale, through the use of "shorter language codes".

Example config:
https://github.com/mozilla/zamboni/blob/master/lib/settings_base.py#L133

Not explicit zh to zh-CN mapping.

In their SVN repo they have zh_CN and zh_TW, just like us
http://svn.mozilla.org/addons/trunk/site/app/locale/

lang_from_accept_header
https://github.com/mozilla/zamboni/blob/master/apps/amo/urlresolvers.py#L211

@ozten ozten referenced this issue in mozilla/persona-yahoo-bridge Mar 6, 2013

Closed

Progress screen isn't responsive, tiny on mobile #129

Member

jrgm commented Mar 6, 2013

actually, @ozten, if I read that right, zamboni will map zh-Hant-TW -> zh-CN, which is wrong.

Member

ozten commented Mar 6, 2013

Agreed, but ... the original reporter of the bug said the got the right localization. So close enough? ;)

Seriously... @mathjazz - care to weigh in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment