Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow geolocate/search lookups without cell/wifi records #165

Closed
hannosch opened this issue Apr 9, 2014 · 3 comments

Comments

@hannosch
Copy link
Collaborator

commented Apr 9, 2014

In addition to cell/wifi databases, we also use a geoip based database now.

So far there are schema checks to ensure clients provide at least one cell or wifi entry in lookups. A geoip-only lookup can be done without a cell or wifi entry.

We should allow that sort of lookup as well and document it. For now you can work around this by providing at least one dummy entry, like a WiFi for 00:00:00:00:00:00.

@hannosch hannosch added the idea label Apr 9, 2014

@garvankeeley

This comment has been minimized.

Copy link

commented May 13, 2014

@hannosch

This comment has been minimized.

Copy link
Collaborator Author

commented May 13, 2014

We should allow lookups that sent an empty JSON mapping {} and return a geo-ip based result. This seems to match the GLS behavior, so we should at least to this for the geolocate and future geosubmit API's. For search we can do whatever is easier to implement.

@graydon

This comment has been minimized.

Copy link
Contributor

commented May 23, 2014

I'm assuming you still want zero-byte requests to be an error, and require the user to have sent "{}"?

@graydon graydon closed this in d69ffba May 24, 2014

hannosch added a commit that referenced this issue May 24, 2014
forivall pushed a commit to freedesktop-unofficial-mirror/geoclue that referenced this issue Apr 22, 2015
wifi: Remove now redundant workaround
This issue is not resolved so no need to keep a workaround for it:

mozilla/ichnaea#165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.