Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Bug 803653] Detect Firefox OS as a platform. #54

Merged
merged 2 commits into from Oct 31, 2012

Conversation

Projects
None yet
2 participants
Member

mythmon commented Oct 31, 2012

Firefox OS doesn't declare a platform because "the web is the platform". This is really unhelpful for Input's purposes, so we are faking it. If something is mobile and doesn't declare a platform, then it must be Firefox OS as a fallback.

Also some clean up in code I ran into.

I'm not entirely certain about this code, so I'd like another set of eyes, and the tests don't really give me much confidence.

f?

mythmon added some commits Oct 30, 2012

[Bug 803653] Detect Firefox OS as a platform.
Firefox OS doesn't declare a platform because "the web is the platform".
This is really unhelpful for Input's purposes, so we are faking it. If
something is mobile and doesn't declare a platform, then it must be
Firefox OS as a fallback.
Member

rlr commented Oct 31, 2012

These changes look good to me. It is similar to what I did in SUMO. I don't have this input set up locally (yet), so if the tests pass for you => r+

Member

mythmon commented Oct 31, 2012

The tests pass with this change as much as they do without this change (I still have a few persistent errors). I'll get this landed and make sure that Jenkin's like it.

@mythmon mythmon merged commit 757cee2 into mozilla:master Oct 31, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment