Prompt for username/password when not in config file. #4

Merged
merged 2 commits into from Jul 12, 2013

Conversation

Projects
None yet
2 participants
@mozbhearsum
Member

mozbhearsum commented Jul 9, 2013

No description provided.

@uberj

This comment has been minimized.

Show comment Hide comment
@uberj

uberj Jul 10, 2013

Contributor

Functionally this looks good. Can you update the README explaining that this type of auth is supported? Also, it would be worth mentioning that you need to completely remove all items under the [authentication] section and that just leaving items empty (like ldap_username =) won't work.

Thanks!

Contributor

uberj commented Jul 10, 2013

Functionally this looks good. Can you update the README explaining that this type of auth is supported? Also, it would be worth mentioning that you need to completely remove all items under the [authentication] section and that just leaving items empty (like ldap_username =) won't work.

Thanks!

@mozbhearsum

This comment has been minimized.

Show comment Hide comment
@mozbhearsum

mozbhearsum Jul 11, 2013

Member

How's this?

Member

mozbhearsum commented Jul 11, 2013

How's this?

@uberj

This comment has been minimized.

Show comment Hide comment
@uberj

uberj Jul 12, 2013

Contributor

r+
I'll merge this tomorrow.

Contributor

uberj commented Jul 12, 2013

r+
I'll merge this tomorrow.

uberj added a commit that referenced this pull request Jul 12, 2013

Merge pull request #4 from bhearsum/username-prompt
Prompt for username/password when not in config file.

@uberj uberj merged commit 45eb4e0 into mozilla:master Jul 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment