Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Aug 18, 2015
  1. @willkg
Commits on Jul 14, 2015
  1. @willkg

    Merge pull request #2596 from mythmon/django-1.7.9

    willkg authored
    [Bug 1182530] Update Django to 1.7.9.
Commits on Jun 15, 2015
  1. @willkg
Commits on Jun 11, 2015
  1. @willkg
Commits on May 21, 2015
  1. @willkg
Commits on May 14, 2015
  1. @willkg
  2. @willkg

    [bug 1164565] Fix max_questions/documents in search suggest api

    willkg authored
    This fixes the code to limit the results returned by max_questions and
    max_documents.
    
    Further, it adds tests for this behavior so that it's less likely to
    break again in the future when I'm making changes.
    
    It also tweaks _make_question() and _make_document() to have a timestamp
    in the title to prevent slug collisions.
Commits on May 13, 2015
  1. @willkg

    [bug 1164565] Fix document results in search suggest API

    willkg authored
    This switches document results to use DocumentDetailSerializer. It also
    fixes DocumentDetailSerializer to include the document summary which is
    on the current revision and the document url.
  2. @willkg

    [bug 1164205] Added api docs for search suggest api

    willkg authored
    I have no idea if this is the format we want to go with, but it is some
    documentation.
    
    Maintaining it will be painful. It's probably better for us to figure
    out a way to autogenerate the documentation or somehow move the
    documentation to the code. That work is covered in bug #1164247.
  3. @willkg

    [bug 1164205] Refactor search suggest api

    willkg authored
    This refactors the search suggest API to use more DRF-y things including
    built-in DRF-y validation.
    
    In the process of doing this, I changed it so that you can provide the filter
    parameters in the querystring OR in the HTTP request body as JSON.
Commits on May 6, 2015
  1. @willkg
  2. @willkg
  3. @willkg

    [bug 1161050] Invalid locales should raise HTTP 400

    willkg authored
    This fixes the search suggest api to return an HTTP 400 if you try to
    filter on an invalid locale.
    
    Further, it fixes the questions search so that it filters on
    locale--previously, it didn't.
    
    Adds some additional tests for behavior that wasn't previously tested.
Commits on May 5, 2015
  1. @willkg
Commits on Apr 27, 2015
  1. @willkg @rlr

    Remove rabbitmq queue size measuring code

    willkg authored rlr committed
    The -stage environment is somehow different than the -dev, -prod and all
    developer environments such that the code we have for measuring the
    rabbitmq queue size is erroring out.
    
    We were faced with two options:
    
    1. remove the problematic code and thus unblock the Django 1.7 upgrade
    
    2. try to fix code that we know is fragile because it uses private
       methods which is broken on only one environment for reasons we
       don't understand  and in a way we can't easily observe the specifics
       of or test fixes for
    
    We chose the first option because the second option is clearly a
    slippery slope to giving up and becoming a potato farmer.  Also, yay
    for -stage environments that differ in mysterious ways from -prod.
  2. @willkg @rlr

    Tweak travis db settings

    willkg authored rlr committed
    This does some db things to try to get around the "MySQL has gone away"
    errors that we're getting on db teardown after all the tests have run.
    
    This only happens in the Travis environment.
  3. @willkg @rlr

    Add display_order to wiki Document initial migration

    willkg authored rlr committed
  4. @willkg @rlr

    Change kitsune.tidings to kitsune.motidings

    willkg authored rlr committed
    This fixes the issue where we had two apps with the same effective app
    name.
Commits on Apr 21, 2015
  1. @willkg

    Get serious with str/unicode in in_review.py

    willkg authored
    Bugzilla returns JSON with utf-8 encoded strings which get converted to
    unicode. So the bugzilla-using code is always dealing with unicode.
    
    git data is pulled from the command line as byte strings. As such, it's
    utf-8 encoded strings.
    
    This commit straightens out the code so that we have everything as
    unicode types and then explicitly encode as utf-8 when printing to the
    command line.
  2. @willkg

    Fix issues with in_review.py

    willkg authored
    * off-by-one with to_date
    * using git-log with a range when we should be using git-show
Commits on Apr 16, 2015
  1. @willkg

    Merge pull request #2478 from AdrianGaudebert/git-ignore-venv

    willkg authored
    No bug - Added venv directory to .gitignore.
Commits on Apr 15, 2015
  1. @willkg
Commits on Apr 10, 2015
  1. @willkg
Commits on Apr 1, 2015
  1. @willkg

    [bug 1038321] Fix l10n issues in messages/views.py

    willkg authored
    This wraps two strings in gettext and fixes a pluralization issue.
Commits on Mar 27, 2015
  1. @willkg

    [bug 1148082] Fix --no-skip

    willkg authored
    nose has a skip plugin which enhances SkipTest raising beyond our
    wildest imaginations. However, there are certain occasions where we want
    skipped things to not skip with reckless abandon but instead don the
    malevolent cloak of errorhood.
    
    nose has a --no-skip argument for exactly this sort of sordid thing, but
    it's totally busted and doesn't work.
    
    This changes the code around so that it works correctly.
Commits on Mar 26, 2015
  1. @willkg

    [bug 1085618] Rework qunit test to be faster and correct

    willkg authored
    The previous version of the qunit test used nose generators to split
    each qunit test into a nose test. That's great, but the setup/teardown
    was "shared" by all the tests which means they had to run in a specific
    order with teardown as the last test. That breaks the requirement that
    tests run independently of one another in any order.
    
    Further, the setup actually executed at collection time, so it'd spin
    up a browser with the qunit page and then at some point down the line,
    the tests would run and examine the contents of that browser window.
    
    This rewrite fixes that by squashing it into one nose test. It prints
    output like this for individual test failures:
    
    QUNIT FAIL: in "declarative": None != None
    
    ======================================================================
    FAIL: kitsune/sumo/tests/test_qunit.py:TestQunit.test_qunit
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/willkg/mozilla/kitsune/kitsune/sumo/tests/test_qunit.py",
    line 59, in test_qunit
        eq_(total_fails, 0, 'One or more Qunit tests failed; see output for
    details')
      File
    "/home/willkg/.virtualenvs/kitsune/lib/python2.7/site-packages/nose/tools.py",
    line 31, in eq_
        assert a == b, msg or "%r != %r" % (a, b)
    AssertionError: One or more Qunit tests failed; see output for details
    
    It'll print a QUNIT FAIL line for each test that failed.
Commits on Mar 25, 2015
  1. @willkg
Commits on Feb 6, 2015
  1. @willkg

    [bug 1122539] Handle the 0 case for documents

    willkg authored
    * handle when max_documents is 0 in a way that's almost a no-op
    * add testing infrastructure to test that documents show up in search
      results and that the code does the right thing when max_documents=0
  2. @willkg

    [bug 1122539] Handle the 0 case

    willkg authored
    If max_questions or max_documents (or both) are 0, then we should do the
    least amount of work and just return [].
Commits on Jan 5, 2015
  1. @willkg

    [bug 1111801] Fix git checkout on Windows

    willkg authored
    Windows file system doesn't like the really long filename we had for
    this test and will balk on git checkout. So we change the test to create
    the file first, then run the test rather than have the file in the repo
    contents.
Commits on Dec 18, 2014
  1. @willkg

    Update dennis to 0.6.1

    willkg authored
    This alleviates some errors with the bg and sq locales.
  2. @willkg
Commits on Dec 17, 2014
  1. @willkg

    Update dennis to 0.6

    willkg authored
    This updates dennis to 0.6. This should add line numbers to the postatus
    reports which will be very nice.
Commits on Dec 11, 2014
  1. @willkg

    Add postatus webapp url to emails

    willkg authored
    The webapp has links to auto-generate bug reports which makes it super
    handy. Adding a link to the email connects the two.
Commits on Dec 4, 2014
  1. @willkg

    [bug 1056298] Fix createsuperuser

    willkg authored
    This adds a patch call to manage.py. The problem is that various
    Django-specific subcommands at some point import Jingo which eventually
    results in a circular import. Adding the patch call here guarantees
    that Jingo and all that stuff is imported before we import the things we
    need to import to execute the subcommand.
Something went wrong with that request. Please try again.