Make warnings on translate page more consistent in tests #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@homu priority=1 |
|
I think, Changing the way it test is a better approach. |
|
I made those changes ^ |
| @@ -1517,8 +1517,7 @@ def _get_next_url_fallback_localization(request): | |||
|
|
|||
| def _show_revision_warning(document, revision): | |||
| if revision: | |||
| return document.revisions.filter(created__gt=revision.created, | |||
| reviewed=None).exists() | |||
| return document.revisions.filter(id__gt=revision.id, reviewed=None).exists() | |||
There was a problem hiding this comment.
This one is Awesome for Future work. Thanks a lot!
|
@homu r+ |
|
Homu seems to have forgotten about us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the tests pass consistently for me, and I think the logic is unchanged (though the result is a bit surprising).
@safwanrahman r?
@homu delegate=safwanrahman