Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INVALID] Update sha256 hashes for .zip dependencies #2861

Closed
wants to merge 1 commit into from
Closed

[INVALID] Update sha256 hashes for .zip dependencies #2861

wants to merge 1 commit into from

Conversation

MikkCZ
Copy link
Contributor

@MikkCZ MikkCZ commented May 8, 2016

https://bitbucket.org/pypa/pypi/issues/436/peep-hash-failures-due-to-being-served-zip has been resolved, but some dependencies are served as .zip archives now a the hash update is needed. The build is working now thanks to the cache https://github.com/mozilla/kitsune/blob/master/.travis.yml#L20 on Travis side.

@glogiotatidis
Copy link
Contributor

How did you update hashes? Did you run peepin for all packages and only those did have zip hashes?

Also please keep commit messages short and to the point. No urls in the commit message, you can add those in the commit description.

@homu
Copy link
Contributor

homu commented May 9, 2016

☔ The latest upstream changes (presumably dae26a4) made this pull request unmergeable. Please resolve the merge conflicts.

@MikkCZ
Copy link
Contributor Author

MikkCZ commented May 9, 2016

No. I have checked, what dependencies are erroring my build and checked their new hashes manually. I will rebase to master and check peepin out.

@MikkCZ
Copy link
Contributor Author

MikkCZ commented May 10, 2016

I have created a very naive script for running peepin for all requirements. Here is the result.

@MikkCZ
Copy link
Contributor Author

MikkCZ commented May 10, 2016

Things I am nut sure they are OK:

  • django-nose==1.4.3 replaced by nose==1.1.2
  • pytest-selenium==1.2.1 replaced by selenium==2.53.2

@MikkCZ
Copy link
Contributor Author

MikkCZ commented May 10, 2016

And the build errored because of wrong hash. :D Even after cleaning the cache here: https://travis-ci.org/MikkCZ/kitsune/jobs/129120905

@glogiotatidis
Copy link
Contributor

Things I am nut sure they are OK:

these are different packages.

@homu
Copy link
Contributor

homu commented Jun 27, 2016

☔ The latest upstream changes (presumably 25c4c1c) made this pull request unmergeable. Please resolve the merge conflicts.

@MikkCZ MikkCZ closed this Jun 30, 2016
@MikkCZ MikkCZ changed the title Update sha256 hashes for .zip dependencies [INVALID] Update sha256 hashes for .zip dependencies Jul 21, 2017
@MikkCZ MikkCZ deleted the peep-hash branch October 19, 2017 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants