Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Locale.locale unique=True to fix #3593 #3594

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
3 participants
@jgmize
Copy link
Member

commented May 7, 2019

@jgmize jgmize requested a review from akatsoulas May 7, 2019

@jgmize jgmize marked this pull request as ready for review May 7, 2019

@jgmize jgmize requested a review from pmac May 7, 2019

@jgmize

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

Note that when I ran ./manage.py makemigrations several other migrations were generated that I have not included in this PR:

  • kitsune/dashboards/migrations/0006_auto_20190506_2016.py
  • kitsune/gallery/migrations/0005_auto_20190506_2016.py
  • kitsune/kbadge/migrations/0003_auto_20190506_2016.py
  • kitsune/questions/migrations/0008_auto_20190506_2016.py

I will follow up on those in a separate issue

Edit: it probably makes more sense to fix #3351 than use the migrations generated above

@jgmize jgmize force-pushed the unique-locales branch from 2fdd84c to fc1e0bc May 7, 2019

@jgmize

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

On further review, only the kbadge migration was unrelated to this change. I've updated this PR to include the additional migrations, and I also removed the now redundant db_index=True

@pmac

pmac approved these changes May 7, 2019

Copy link
Member

left a comment

Thanks Josh 💯

@jgmize jgmize merged commit 2d47e9a into master May 7, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@jgmize jgmize deleted the unique-locales branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.