Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set SKIP_MOBILE_DETECTION=True in prod #3608

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
4 participants
@metadave
Copy link
Member

commented May 7, 2019

already deployed to frankfurt, oregon-a, oregon-b

I suppose this branch needs to be created against prod...

@metadave metadave requested review from pmac, jgmize and jpetto May 7, 2019

@metadave metadave closed this May 7, 2019

@metadave metadave reopened this May 7, 2019

@jpetto

jpetto approved these changes May 8, 2019

Copy link
Member

left a comment

LGTM. Just clarifying that this will result in a worse mobile experience that we'll need to address in the near future.

(This is the best fix for an urgent issue though.)

@jpetto

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Waiting on merging just in case. (These changes are already deployed.)

@pmac

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Yes. There might be a better solution which hopefully we can discuss tomorrow. Maybe we can make google go back to primarily using the desktop bot, or we can remove the noindex tag from the mobile pages, or we can modify our mobile detection to always see the google bot as desktop. I'm hoping Raphael will have some advice.

@jgmize

jgmize approved these changes May 9, 2019

@jgmize jgmize merged commit e12064d into master May 9, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@jgmize jgmize deleted the dp_skip_mobile_detection branch May 9, 2019

jgmize added a commit that referenced this pull request May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.