Unified 755726 #660
Closed
Unified 755726 #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some bugs that I discovered when running the tests. The tests are literlaly the existing ElasticViewTests with the esunified waffle flag on.
This adds the same weights we use for Sphinx to the ES unified search results view code. We'll iterate on the numbers after analysis is done.
|
I added the weights in the last commit. r? |
| # results--for every hit it gets back from ES, it creates an | ||
| # object of the type of the Django ORM model you passed in. We use | ||
| # object here to satisfy the need for a type in the constructor | ||
| # and make sure we don't ever ask for object results. |
|
tests pass and I HAZ UNIFIED RESULTS. Let's get this shipped and move on to the next step, r+! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements elasticsearch unified search results. Also adds a basic round of tests though they're pretty much copy-and-paste from the existing ES tests.
This could use some more work, but this is a good first pass.
r?