Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 757202: miscellaneous Table of Contents fixes #220

Merged
merged 2 commits into from May 24, 2012

Conversation

Projects
None yet
2 participants
Contributor

nickolay commented May 21, 2012

  • Set initial value for the check box on edit_document appropriately.
    (apps/wiki/forms.py)
  • Add the TOC checkbox on the new_document page.
  • Enable TOC on new pages by default (apps/wiki/views.py)
  • Change the checkbox label to fit the label's width

See https://bugzilla.mozilla.org/show_bug.cgi?id=757202 for details.

Bug 757202: miscellaneous Table of Contents fixes
* Set initial value for the check box on edit_document appropriately.
  (apps/wiki/forms.py)
* Add the TOC checkbox on the new_document page.
* Enable TOC on new pages by default (apps/wiki/views.py)
* Change the checkbox label to fit the label's width

@groovecoder groovecoder and 1 other commented on an outdated diff May 23, 2012

apps/wiki/templates/wiki/edit_document.html
@@ -105,7 +105,9 @@
<ul class="metadata">
<li><label>{{_('Title:')}}</label> {{ revision_form.title | safe }}</li>
<li><label>{{_('Slug:')}}</label> {{ revision_form.slug | safe }}</li>
- <li><label>{{_('Generate table of contents:')}}</label> {{ revision_form.show_toc | safe }}</li>
+ <li><label><abbr title="{{_('Generate table of contents:')}}">{{_('TOC')}}</abbr></label>
@groovecoder

groovecoder May 23, 2012

Owner

nit: Generate table of contents and TOC:

@nickolay

nickolay May 23, 2012

Contributor

Good catch, thanks!

@groovecoder groovecoder commented on an outdated diff May 23, 2012

apps/wiki/templates/wiki/new_document.html
@@ -26,6 +26,9 @@
<li><label>{{_('Slug:')}}</label> {{ document_form.slug | safe }}</li>
<li><label>{{_('Parent:')}}</label> {{ document_form.parent_topic | safe }}</li>
<li><label>{{_('Tags:')}}</label> {{ revision_form.tags | safe }}</li>
+ <li><label><abbr title="{{_('Generate table of contents:')}}">{{_('TOC')}}</abbr></label>
@groovecoder

groovecoder May 23, 2012

Owner

same nit as above

groovecoder added a commit that referenced this pull request May 24, 2012

Merge pull request #220 from nickolay/757202-table-of-contents
Bug 757202: miscellaneous Table of Contents fixes

@groovecoder groovecoder merged commit 56bccba into mozilla:master May 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment