Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Fix bug 1078186: Redirect static canvas examples to wiki pages #3033

Merged
merged 1 commit into from Feb 13, 2015
Merged

Fix bug 1078186: Redirect static canvas examples to wiki pages #3033

merged 1 commit into from Feb 13, 2015

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Jan 29, 2015

This looks ugly, but having these old static pages as top results in Google is ugly, too. Especially now that we have better docs in the wiki :) See https://bugzilla.mozilla.org/show_bug.cgi?id=1078186

I am wondering if this will actually work, given there is also this in line 12:
RewriteRule ^samples(.*) data/www/samples$1 [L]

@groovecoder
Copy link
Contributor

Yes - mod_rewrite will process them top-to-bottom, so you'll have to put the more specific rewrite regex's above the more generic one.

@groovecoder
Copy link
Contributor

ping @Elchi3 - are you able to move the rewrites up above the generic ^samples(.*) one?

@Elchi3
Copy link
Member Author

Elchi3 commented Feb 6, 2015

Sorry for the delay, was attending a conference :) I moved the rules up above the generic rules and I tested some of the URLs using this tool: http://htaccess.madewithlove.be/.

@groovecoder groovecoder self-assigned this Feb 12, 2015
@groovecoder
Copy link
Contributor

Looking good. Need to add the NE flag to all the RewriteRules so the # characters aren't escaped away.

@groovecoder
Copy link
Contributor

E.g.,

RewriteRule ^samples/canvas-tutorial/2_1_canvas_rect.html$ docs/Web/API/Canvas_API/Tutorial/Drawing_shapes#Rectangular_shape_example [NE,R=301,L,NC]

@Elchi3
Copy link
Member Author

Elchi3 commented Feb 13, 2015

Updated.

@groovecoder
Copy link
Contributor

Looks good, thanks!

groovecoder added a commit that referenced this pull request Feb 13, 2015
Fix bug 1078186: Redirect static canvas examples to wiki pages

r=groovecoder
@groovecoder groovecoder merged commit bb267d4 into mdn:master Feb 13, 2015
@Elchi3 Elchi3 deleted the bug1078186 branch March 19, 2015 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants