Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
implement SCL3 httpd redirects in Django #4220
This PR uses @pmac's https://github.com/pmac/django-redirect-urls lib to implement SCL3 Apache httpd redirects in Python/Django. The complex rewrites retain original mod_rewrite rules as comments, while the remaining are uncommented simple static redirects. Test layout is similar to the Bedrock redirect tests.
The only rewrite rule that isn't implemented in this PR is as follows:
which redirects requests to
Tracked in this infra issue
@@ Coverage Diff @@ ## master #4220 +/- ## ========================================== + Coverage 86.31% 86.31% +<.01% ========================================== Files 147 148 +1 Lines 9103 9105 +2 Branches 1222 1222 ========================================== + Hits 7857 7859 +2 Misses 1005 1005 Partials 241 241
I think we need the
base_url fixture, so that you can verify that the new Kuma code matches the behavior of production. The
[url12] test of
/media/uploads/demos/foobar looks to be a real bug.
As for the
There's some missing stuff:
but, I'm happy with what is here so far. It's up to @metadave if he wants to keep working in this PR, or merge and add further refinements in a future PR.
@jwhitlock I pushed some fixes to get all the tests to pass on
which correspond to the following rewrites:
I'd prefer to submit * the .htaccess redirects in a separate PR.
I'll wait for Travis to turn green and merge.