New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1370965: Fix context menu to work again. #4262

Merged
merged 1 commit into from Jun 13, 2017

Conversation

Projects
None yet
3 participants
@a2sheppy
Contributor

a2sheppy commented Jun 13, 2017

Firefox has made it so you need to set the location object with window.location instead of just location recently, so this changes the code to work again.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 13, 2017

Codecov Report

Merging #4262 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4262   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         162      162           
  Lines       10022    10022           
  Branches     1367     1367           
=======================================
  Hits         8806     8806           
  Misses        989      989           
  Partials      227      227

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1a96c...3e65564. Read the comment docs.

codecov-io commented Jun 13, 2017

Codecov Report

Merging #4262 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4262   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         162      162           
  Lines       10022    10022           
  Branches     1367     1367           
=======================================
  Hits         8806     8806           
  Misses        989      989           
  Partials      227      227

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1a96c...3e65564. Read the comment docs.

@jwhitlock jwhitlock self-requested a review Jun 13, 2017

@jwhitlock

👍 works in Firefox. Thanks, @a2sheppy!

@jwhitlock jwhitlock merged commit 9c2ca2f into mozilla:master Jun 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment