New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1370514 - fixed links in editing mode #4286

Merged
merged 2 commits into from Jun 30, 2017

Conversation

Projects
None yet
3 participants
@karabellyj
Contributor

karabellyj commented Jun 22, 2017

@jwhitlock jwhitlock self-requested a review Jun 22, 2017

@jwhitlock jwhitlock self-assigned this Jun 22, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 22, 2017

Codecov Report

Merging #4286 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4286      +/-   ##
==========================================
+ Coverage   87.83%   87.83%   +<.01%     
==========================================
  Files         162      162              
  Lines       10042    10045       +3     
  Branches     1371     1371              
==========================================
+ Hits         8820     8823       +3     
  Misses        993      993              
  Partials      229      229
Impacted Files Coverage Δ
kuma/wiki/templatetags/jinja_helpers.py 88.52% <100%> (+0.38%) ⬆️
kuma/settings/common.py 94.28% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b68131...97599fe. Read the comment docs.

codecov-io commented Jun 22, 2017

Codecov Report

Merging #4286 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4286      +/-   ##
==========================================
+ Coverage   87.83%   87.83%   +<.01%     
==========================================
  Files         162      162              
  Lines       10042    10045       +3     
  Branches     1371     1371              
==========================================
+ Hits         8820     8823       +3     
  Misses        993      993              
  Partials      229      229
Impacted Files Coverage Δ
kuma/wiki/templatetags/jinja_helpers.py 88.52% <100%> (+0.38%) ⬆️
kuma/settings/common.py 94.28% <0%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b68131...97599fe. Read the comment docs.

@jwhitlock

This comment has been minimized.

Show comment
Hide comment
@jwhitlock

jwhitlock Jun 27, 2017

Member

@karabellyj thanks for helping fix this!

There's a bug with wiki_url when passing a fragment like #The_attachments_box - it's adding it to the URL like MDN/Contribute/Editor/Basics%23The_attachments_box, which leads to creating a new page. This leads to creating a new page with the title "Basics%23The_attachments_box", not linking to that part of the page. I believe the redirect was somehow masking this bug.

I'm going to try to add a follow-on commit, so that we can fix both of these issues at the same time.

Member

jwhitlock commented Jun 27, 2017

@karabellyj thanks for helping fix this!

There's a bug with wiki_url when passing a fragment like #The_attachments_box - it's adding it to the URL like MDN/Contribute/Editor/Basics%23The_attachments_box, which leads to creating a new page. This leads to creating a new page with the title "Basics%23The_attachments_box", not linking to that part of the page. I believe the redirect was somehow masking this bug.

I'm going to try to add a follow-on commit, so that we can fix both of these issues at the same time.

@jwhitlock jwhitlock merged commit 90e035a into mozilla:master Jun 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment