New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug 1418301, updates preload urls #4537

Merged
merged 1 commit into from Nov 22, 2017

Conversation

Projects
None yet
3 participants
@schalkneethling
Collaborator

schalkneethling commented Nov 17, 2017

Updates the preload urls to the new endpoints. I removed the as="document" as it seems this is not supported in Chrome release either so, we are not getting any benefit from this.

@schalkneethling schalkneethling requested a review from stephaniehobson Nov 17, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 17, 2017

Codecov Report

Merging #4537 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4537   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files         262      262           
  Lines       23154    23154           
  Branches     1669     1669           
=======================================
  Hits        22027    22027           
  Misses        909      909           
  Partials      218      218

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f663a8c...ac355e3. Read the comment docs.

codecov-io commented Nov 17, 2017

Codecov Report

Merging #4537 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4537   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files         262      262           
  Lines       23154    23154           
  Branches     1669     1669           
=======================================
  Hits        22027    22027           
  Misses        909      909           
  Partials      218      218

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f663a8c...ac355e3. Read the comment docs.

@stephaniehobson stephaniehobson self-assigned this Nov 17, 2017

@stephaniehobson

We are removing the A/B test so this entire block should just be removed (or updated for use outside this test page as you suggested in email)

@schalkneethling

This comment has been minimized.

Show comment
Hide comment
@schalkneethling

schalkneethling Nov 20, 2017

Collaborator

@stephaniehobson After reading the spec again, I would say it is safe to simply add these to the page without a conditional. The first time it is encountered the browser will fetch the resource and cache it.

As this early fetch it is not render blocking, this simply means that once the user does get to a page with the "editor", the JS will be instantly loaded, parsed and executed from browser cache. Thoughts?

Collaborator

schalkneethling commented Nov 20, 2017

@stephaniehobson After reading the spec again, I would say it is safe to simply add these to the page without a conditional. The first time it is encountered the browser will fetch the resource and cache it.

As this early fetch it is not render blocking, this simply means that once the user does get to a page with the "editor", the JS will be instantly loaded, parsed and executed from browser cache. Thoughts?

@stephaniehobson stephaniehobson merged commit 08d1035 into mozilla:master Nov 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment