This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
bug 1431259: Don't cache the "create page" redirect #4731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhitlock
changed the title
escattone
suggested changes
Apr 6, 2018
There was a problem hiding this comment.
Other than one requested change, this looks great, and I think it's a great idea! The first time the non-existent doc endpoint is hit, the redirect will not be cached. Only on the second and subsequent hits will we tell the CDN to cache the response. Thanks @jwhitlock!
kuma/core/decorators.py
Outdated
| def _cache_controlled(request, *args, **kw): | ||
| response = viewfunc(request, *args, **kw) | ||
| nocache = (response.has_header('Cache-Control') and | ||
| 'no-cache' in response['Cache-Control']) |
There was a problem hiding this comment.
I think we should add
and 'no-store' in response['Cache-Control']as well, since either could be used independent of the other.
jwhitlock
force-pushed
the
keep-no-cache-1431259
branch
from
d59d36c
to
278519c
Compare
Use a "no-cache" cache control header when redirecting to create a page, to avoid a loop where you have to wait for the cache to expire to see the new page. This also updates the shared_cache_control decorator to take no action if it detects the cache control header is set to no-cache.
jwhitlock
force-pushed
the
keep-no-cache-1431259
branch
from
278519c
to
b8e44b2
Compare
|
Force-update to check for |
escattone
approved these changes
Apr 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a "no-cache" cache control header when redirecting to create a page, to avoid a loop where you have to wait for the cache to expire to see the new page. This also updates the
shared_cache_controldecorator to take no action if it detects the cache control header is set to no-cache.