New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug 1429933] remove depreciated CELERYD_LOG_LEVEL #4748

Merged
merged 1 commit into from May 3, 2018

Conversation

Projects
None yet
2 participants
@mashrikt
Contributor

mashrikt commented Apr 23, 2018

Removed CELERYD_LOG_LEVEL from kuma/settings/common.py
Used --loglevel flag in docker-compose.yml command instead.

This does not completely remove the RemovedInDjangoXXXWarnings, since I haven't added the SessionAuthenticationMiddleware. It is no longer required in Django 1.10 and Session verification is enabled regardless.

Session verification is enabled regardless of whether or not 'django.contrib.auth.middleware.SessionAuthenticationMiddleware' is in MIDDLEWARE_CLASSES. SessionAuthenticationMiddleware no longer has any purpose and can be removed from MIDDLEWARE_CLASSES. It’s kept as a stub until Django 2.0 as a courtesy for users who don’t read this note.

@jwhitlock

This comment has been minimized.

Member

jwhitlock commented Apr 24, 2018

Thanks @mashrikt. I prefer small PRs with a single topic, so it is OK if this doesn't clear all the deprecation warnings. I believe there are more generated if you run the tests or other management commands, but it has been a while since I've done that.

Production doesn't use the development docker-compose.yml, so I'll need to make a similar change to the production config before merging this.

@mashrikt

This comment has been minimized.

Contributor

mashrikt commented Apr 24, 2018

Thanks @jwhitlock
Do let me know if there is anything I can do.

@jwhitlock

The production configuration has been updated to pass --loglevel=INFO, so this is now safe to merge. Thanks @mashrikt!

@jwhitlock jwhitlock merged commit 35fa39c into mozilla:master May 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mashrikt

This comment has been minimized.

Contributor

mashrikt commented May 4, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment