New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title in code samples #811001 #4767

Merged
merged 8 commits into from May 9, 2018

Conversation

Projects
None yet
3 participants
@Ladeia
Contributor

Ladeia commented May 6, 2018

I add charset and a title for code samples pages.

@jwhitlock

This comment has been minimized.

Member

jwhitlock commented May 7, 2018

Thanks @Ladeia. The code looks correct, but the tests are failing. Do you want to fix the tests, or do you need some help?

Antonio Ladeia and others added some commits May 7, 2018

@jwhitlock

Thanks @Ladeia, this looks like a good change.

The <meta charset="utf-8"> needs to be just after the <head> element, which impacts the template and the test.

@@ -7,6 +7,8 @@
{{ css|safe }}
</style>
{% endif %}
<meta charset="utf-8">

This comment has been minimized.

@jwhitlock

jwhitlock May 8, 2018

Member

This should be just after the <head> element.

@codecov-io

This comment has been minimized.

codecov-io commented May 8, 2018

Codecov Report

Merging #4767 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4767      +/-   ##
==========================================
- Coverage   95.82%   95.81%   -0.01%     
==========================================
  Files         270      270              
  Lines       24568    24563       -5     
  Branches     1750     1750              
==========================================
- Hits        23542    23535       -7     
- Misses        814      815       +1     
- Partials      212      213       +1
Impacted Files Coverage Δ
kuma/wiki/tests/test_views_code.py 100% <ø> (ø) ⬆️
kuma/wiki/views/code.py 100% <100%> (ø) ⬆️
kuma/users/signal_handlers.py 81.96% <0%> (-3.28%) ⬇️
kuma/core/tests/test_commands.py 100% <0%> (ø) ⬆️
kuma/core/tests/test_views.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a34764...4203a94. Read the comment docs.

@jwhitlock

Thabks @Ladeia, looks good!

@jwhitlock jwhitlock merged commit 25ddd31 into mozilla:master May 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json No dependency changes
Details

@Ladeia Ladeia deleted the Ladeia:add-title-in-code-samples-811001 branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment