New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): remove aria-hidden from social svg #4776

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
2 participants
@schalkneethling
Collaborator

schalkneethling commented May 11, 2018

This removes aria-hidden from the social SVG icons so that the SVG elements are exposed to the a11y tree.

@schalkneethling schalkneethling requested a review from jwhitlock May 11, 2018

@schalkneethling

This comment has been minimized.

Collaborator

schalkneethling commented May 19, 2018

@jwhitlock @escattone If either one of you have a moment, I would appreciate getting this one out the door. Thanks!

@jwhitlock

Looks good, thanks @schalkneethling!

@jwhitlock jwhitlock merged commit 044dddc into mozilla:master May 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json No dependency changes
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment