Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Bug 1490392: Reduce web font usage #4967
This PR addresses https://app.zenhub.com/workspace/o/mdn/sprints/issues/255 by removing Zilla Slab Italic in favor of font synthesis and eliminating Open Sans and using Verdana instead.
This drops our web font count from 6 to 2, decreases our font weight by 39% (211.4kb) and improves reduces the amount of rendering work the browser has to do.
Looks good, with one nit. I tried some pages locally, and built the production docker images to make sure there aren't some missing paths.
I suspect Gaia is an old MDN project that we can get rid of soon, but can be done after this PR.
@tkadlec I am going to suggest that we add the following to the
A large portion of our audience will get the benefit and it really makes the copy a lot more readable:
I notice that the newsletter section overrides
The same is happening on production so, was not introduced here but, thought I would mention it. @jwhitlock you know of a specific reason for this?
Update: This seems intentional and works well when the newsletter signup is at the bottom of the page. Just looks a little odd in this instance.
Sep 13, 2018
2 checks passed
I love the size reduction of page loads here, but there are definitely some text legibility problems introduced by this. Letter spacing is a little too broad, especially for bold type, and is really pretty bad when looking at bold type in the editor, as seen in this screen shot:
Previously, this was much more legible, looking something like this (this is sort of a recreation made by tweaking the CSS to restore Open Sans as the body font):