New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in content icons to svg stage1 #4969

Merged
merged 2 commits into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@schalkneethling
Collaborator

schalkneethling commented Sep 12, 2018

@jwhitlock @hobinjk r? ~ This is the first pull request for in content icons. This PR cleans up the CSS and fonts to only reference and contain icons that are being used on MDN Web Docs.

I have tested a whole lot of pages as well as the JS and HTML reference sidebars(macros), CKEditor, edit preview, tutorial pages and all icons still work as before.

Next step, post-merge, is to change from referencing PUAs in the font to SVG files.

Size of fonts before:

screen shot 2018-09-10 at 15 46 33

Size of fonts now:

screen shot 2018-09-12 at 10 39 32

Note: This should be merged and pushed to production separate from Tim's PR here #4967

@hobinjk

hobinjk approved these changes Oct 1, 2018

Tested locally and LGTM

@schalkneethling

This comment has been minimized.

Collaborator

schalkneethling commented Oct 2, 2018

Thanks @hobinjk ~ @jwhitlock you happy to merge this one?

@jwhitlock

This comment has been minimized.

Member

jwhitlock commented Oct 2, 2018

Yep, thanks @schalkneethling and thanks for the review @hobinjk!

@jwhitlock jwhitlock merged commit 257a32b into mozilla:master Oct 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (mdn) No manifest changes detected

@schalkneethling schalkneethling referenced this pull request Oct 17, 2018

Closed

Missing indicator icons #512

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment