New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1493499, add aria roles to notes/warning boxes inside ckeditor #5069

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@schalkneethling
Copy link
Collaborator

schalkneethling commented Nov 2, 2018

To test this, edit a page on MDN. In CKEditor, choose the "Note" component from the Styles dropdown. Switch to the source output, confirm that the following is output:

<div class="note" role="complementary">
<p>&nbsp;</p>
</div>

Switch back to the WYSIWYG and add a "Warning" component. Switch to source and confirm that the output is as follows:

<div aria-label="Important note" class="warning" role="region">
<p>&nbsp;</p>
</div>

r?

@ExE-Boss

This comment has been minimized.

Copy link
Contributor

ExE-Boss commented Nov 12, 2018

This now needs rebasing on top of #5079 (b6baa5c)

@schalkneethling schalkneethling force-pushed the schalkneethling:bug1493499-add-aria-roles-no-notes-boxes branch from aaf7f86 to b76b5c4 Nov 13, 2018

@schalkneethling schalkneethling merged commit c52f18d into mozilla:master Nov 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (mdn) No new, high severity issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment