Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
bug 1467518: Migration from Python 2 to Python2/3 #5071
left a comment
Thanks @MatonAnthony, this is a big step forward!
Before this change:
After this change:
I think you identified some further changes, and I have some nits. Since this doesn't break any Python 2 code, I'm approving as it is. Let me know if you want it merged (merge commit looks right to me) or if you want to continue working on it.
The test failure is the Docker image, and it appears that getting the GPG keys for the node package is failing. Restarting doesn't help. We saw similar issues when node 8 was made the LTS version, and the build became more reliable when we updated. node 10 was made the designated LTS version a few weeks ago. We can ignore it, and it may be better when someone kicks the server on Monday.
Snyk looks at the package.json in your PR and compares it to master. We recently updated package.json to avoid some security vulnerabilities, but your PR was branched before this change. The snyk warning can be ignored, and a rebase will fix it.