Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Bug 1513203, add Jest and True, and initial tests #5162
@davidflanagan As mentioned in the bug, this adds two frameworks:
For True I had to also add Mocha as the test runner. I am looking into writing a little bridge so I can also run True with Jest, so that is temporary. I also added a small number of tests for each.
After this is merged, I will be pushing a lot more tests for both. r?
davidflanagan left a comment
Thanks for asking me to review this Schalk. I learned a lot about Jest, True, and our own codebase.
I've left a number of suggestions, most of which are nits and not blocking.
But I am requesting changes because I think that the new utils file you create here doesn't appear to get bundled into build/js/payments.js where it is used. Maybe I just don't understand how we bundle the code, but I'm worried that this will break the payments flow as it stands.