New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1462400: fix test_footer_language_selector test #5163

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@escattone
Copy link
Member

escattone commented Dec 11, 2018

This PR fixes the test_footer_language_selector test within tests/functional/test_language_selector.py. The payments banner was obscuring the click on the language selector in the footer, so the fix was simply to close it. I think I'll skip the details of how I overlooked something that made me waste an entire day in frustration on this 🤦‍♂️.

@escattone escattone requested a review from jwhitlock Dec 11, 2018

@escattone escattone referenced this pull request Dec 13, 2018

Closed

Fix integration/acceptance test suite #155

3 of 3 tasks complete
@jwhitlock
Copy link
Member

jwhitlock left a comment

Thanks, looks good. I look forward to your blog post on the other time-wasting issue 😁

There's a WAFFLE_OVERRIDE setting that can be used to turn a waffle-controlled feature on and off:

https://waffle.readthedocs.io/en/stable/testing/automated.html#external-test-suites

My guess is that payments will turn into an "always on" feature someday, but this may help with other features like random surveys.

@jwhitlock jwhitlock merged commit 76f6dbe into mozilla:master Dec 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (mdn) No new, high severity issues
Details

@escattone escattone deleted the escattone:fix-footer-lang-select-test-1462400 branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment