Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upbug 1462400: fix test_header_signin and test_edit_sign_in #5166
Conversation
escattone
requested a review
from
jwhitlock
Dec 13, 2018
escattone
referenced this pull request
Dec 13, 2018
Closed
Fix integration/acceptance test suite #155
jwhitlock
approved these changes
Dec 13, 2018
|
Looks good, thanks @escattone! It looks like our "we're on GitHub" detection is more consistent across tests. This is the one I should have added the comment about forcing waffle flags for external testing. I think it is OK to use the existing |
jwhitlock
merged commit 175a645
into
mozilla:master
Dec 13, 2018
escattone
deleted the
escattone:avoid-survey-obscuration-1462400
branch
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
escattone commentedDec 13, 2018
Both of these tests:
tests/functional/test_article.py::test_header_signintests/functional/test_article_edit.py::test_edit_sign_inwould sometimes fail due to their buttons being obscured by the task-completion survey, so I disabled the survey prior to clicking. I also removed the
trigger_signinmethod from theHeaderclass, replacing it with.signin_link.click(), as I thought it was more direct and readable (i.e., the method led me to think it was doing something more than just clicking on the sign-in link).