Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
bug 1462400: fix test_header_signin and test_edit_sign_in #5166
Both of these tests:
would sometimes fail due to their buttons being obscured by the task-completion survey, so I disabled the survey prior to clicking. I also removed the
jwhitlock left a comment
Looks good, thanks @escattone! It looks like our "we're on GitHub" detection is more consistent across tests.
This is the one I should have added the comment about forcing waffle flags for external testing. I think it is OK to use the existing