New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1462400: fix test_header_signin and test_edit_sign_in #5166

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@escattone
Copy link
Member

escattone commented Dec 13, 2018

Both of these tests:

  • tests/functional/test_article.py::test_header_signin
  • tests/functional/test_article_edit.py::test_edit_sign_in

would sometimes fail due to their buttons being obscured by the task-completion survey, so I disabled the survey prior to clicking. I also removed the trigger_signin method from the Header class, replacing it with .signin_link.click(), as I thought it was more direct and readable (i.e., the method led me to think it was doing something more than just clicking on the sign-in link).

bug 1462400: fix test_header_signin and test_edit_sign_in
Both of these tests would sometimes fail due to their buttons
being obscured by the task-completion survey. Disable the survey
prior to clicking.

@escattone escattone requested a review from jwhitlock Dec 13, 2018

@escattone escattone referenced this pull request Dec 13, 2018

Closed

Fix integration/acceptance test suite #155

3 of 3 tasks complete
@jwhitlock
Copy link
Member

jwhitlock left a comment

Looks good, thanks @escattone! It looks like our "we're on GitHub" detection is more consistent across tests.

This is the one I should have added the comment about forcing waffle flags for external testing. I think it is OK to use the existing page.disable_survey_popup, which may even do what it says 😀.

@jwhitlock jwhitlock merged commit 175a645 into mozilla:master Dec 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (mdn) No new, high severity issues
Details

@escattone escattone deleted the escattone:avoid-survey-obscuration-1462400 branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment