Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Check in fibers & optimist dependencies to node_modules. #15

Closed
wants to merge 3 commits into from

2 participants

@nickolay

Currently with a clean checkout npm complains about unmet dependencies:

(kuma-venv)[vagrant@kuma kumascript]$ npm list
npm WARN fibers 0.6.4 Unmet dependency in /vagrant/kumascript
npm WARN optimist 0.3.x Unmet dependency in /vagrant/kumascript/node_modules/nconf

Also optimist is not listed in package.json, making it appear as "extraneous" after you install it.

I did an "npm install fibers && npm install optimist" followed by git commit, looks like that's how one is supposed to add dependencies to node_modules...

@lmorchard

Hmm, I actually had to remove node-fibers from the repo a few weeks ago. That package has a binary module component that needs to be compiled, and anything like that needs to be built and wrapped in an RPM for installation on Mozilla servers. For non-Mozilla servers (like a vagrant box, etc), an npm install should pick it up.

As for optimist... hmm, that should probably appear under node_modules/nconf/node_modules/optimist, if it's a pre-req for nconf.

nickolay added some commits
@nickolay nickolay This reverts commit b43657e. 2f3c69d
@nickolay nickolay Add missing node_modules.
- commit 'optimist' required by 'nconf'
- 'fibers' is a compiled module, which must be deployed as an RPM to
  Mozilla servers, so just add it to gitignore.
6a4c0b1
@nickolay

@lmorchard thanks for the link. The reason I wanted this checked in was that git complains endlessly about untracked content after you 'npm install' the requirements. Would adding node_modules/fibers to .gitignore be acceptable?

Re: optimist, I didn't think npm would install dependencies to node_modules/nconf/node_modules automatically. Thanks for the tip! (ran npm uninstall nconf && npm install nconf and committed the result)

@lmorchard

Sorry it took me so long to get around to this, but:
d251f2a

@lmorchard lmorchard closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 28, 2012
  1. @nickolay
Commits on May 29, 2012
  1. @nickolay

    This reverts commit b43657e.

    nickolay authored
  2. @nickolay

    Add missing node_modules.

    nickolay authored
    - commit 'optimist' required by 'nconf'
    - 'fibers' is a compiled module, which must be deployed as an RPM to
      Mozilla servers, so just add it to gitignore.
Something went wrong with that request. Please try again.