Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] Some accessibility fixes for modals #1034
This makes some a11y fixes for our modals (some specific to club modals):
Things still left to do:
referenced this pull request
Jun 18, 2015
VoiceOver reads it as "Window" and I can't get inside of the div
After the form has been successfully submitted, VoiceOver reads the button text "Take Me To My Club" and skips everything else.
(Side note: for really annoying cross-browser issues like this, we can at least use UA detection as a last resort, but I don't think we can here, since there doesn't appear to be a way to detect what screen reader is being used.)
Since the current PR doesn't degrade VoiceOver performance but improves NVDA performance, I think we should leave the behavior as-is and just add unit tests for what we've got here and land these changes. What do you think @mmmavis ?
Hey @toolness , thanks for sharing links to those useful posts.
I know we haven't decided on our browser support but a11y-wise I'm wondering if we should focus on just a few platform combos(e.g., FF on Mac OSX with VoiceOver, Chrome on Windows with NVDA... something like that). It's