This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
better 'return to badge' styling, and a content switch on application… #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gideonthomas
approved these changes
Oct 19, 2016
|
|
||
| if (error) { | ||
| return ( | ||
| <Modal className="modal-credly error folded" hideModal={this.state.canCloseModal? this.hideApplyModal : false}> |
There was a problem hiding this comment.
I don't understand? before what? and is there space, or should there be space?
There was a problem hiding this comment.
sorry, I meant in the ternary condition, can we add a space between the condition and the ? operator?
|
added a space, although that's not a thing we;ve set up a js style rule for so atm either is "fine" from a linting perspective |
|
feel free to merge in anytime |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centers the "return to badge" button in the application confirmation dialog, and also adds a context switch so that the modal cannot be closed until the POST request has properly finished - if the POST fails (not-200-return) the content is switch out for an error notice and a request to contact us, with a red button rather than yellow.